-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use yarn as a "quick-and-easy" way to hack the editor #6
Conversation
It actually breaks yarn build and some commands on electron-rebuild and electron-build
I really feel the easier we can make running and testing the editor, the better for newcomers, and the easier it is for you to get help within core. I'm all for it |
I think it looks good! though can't see how the playwright related dev dependencies are used? |
@autumnblazey you're right, there are things that came from my base branched that should not be here. I'll update the PR, and also add some documentation on it |
alrigty! and no problem |
Wait if it runs on node 16 maybe we should be targeting that? That's the newest lts and gets us up to date (for now). That would allow for further optimizations to be pushed that we probably couldn't get in the older releases possibly. Not to mention the fact going forward we would be able to replace or drop extraneous packages either internally or from npm. Since I know a lot of ones from npm are likely to break sooner or later with how out of date some are. |
Just saw the changes you've made to fixing the devDependencies, looks rad |
This works on fedora, had to install a bit of extra stuff but it works(probably the same for other rpm based distros since I assume they've all got the same package names. Commands for this are: Needs toolbox to have a standardized build environment:
Then once inside the toolbox:
|
This PR adds support for running:
As a way to quickly open up the text editor, instead of going though the trouble of running the bootstrap script. It also runs on Node 16, and it's completely non-invasive.
So, opinions on it?