Merge decaffinated master into rebrand #29
Conversation
To make atom-community/atom#386 reviewable, that pr will be separated into many simpler prs. This is one of them. This first commit does the following: - update package.json - update package-lock.json using `./script/build` which also seems to update `apm/package-lock.json` - update packages/README.md - clone all language packages. Specifically: - `mkdir packages/language-<all of them>` - `cd packages/about` - For all languages: - `cd ../language-<>` - `git clone language-<>` - Move all files except `.git` from `language-<>/language-<>` to `language-<>` - delete `language-<>/language-<>` Since at first I accidentally updated `dependencies` then `packageDependencies`, it appears that since the versions of language-c, language-css, language-go, language-javascript, and language-sass don't match, `dependencies` was reset for those versions. [Those repos just happen to be precisely the ones that have tree-sitter v19](https://github.com/icecream17/atom-update-backlog/blob/main/Languages.md), (sans language-sass), which [currently breaks atom](atom/atom#22129). So even though their repos are now in `packages`, **I've decided to not use them**. This is done by updating `packageDependencies` only for non-breaking languages.
Co-authored-by: confused_techie <dev@lhbasics.com>
Co-authored-by: Steven Nguyen <nguyeste008@students.garlandisd.net>
remove all references to atom or atom community
Bump tree sitter
Decaffeinate all the core editor's files
There was a problem hiding this comment.
Apologies about having so many suggestions here, but for being a rebrand effort its best to be as thorough as possible, right? Now realistically I got about halfway through your PR, down to packages/langauge-git/package.json is where I ended with making suggestions. I'm hoping to go back through these all.
I've tried to make things as easy as possible by using commit suggestions, so they can be one click applied if deemed applicable.
Some standouts here, the now bundled repos, package.json has lots of data still relating to previous usage, now an example of how these where handled by upstream can be found on the welcome package, where any repository key points to https://github.com/pulsar-edit/pulsar. So I would think we want to do the same.
Additionally many of these packages include build information, which can likely be removed, as that will be inherited by whatever build info is available for the editor itself.
| @@ -36,7 +36,7 @@ | |||
| "atom-select-list": "^0.8.1", | |||
There was a problem hiding this comment.
Do we want to take this opportunity to rename this item to pulsar-select-list, we would need to publish it to npm under the new name, but might be a good idea.
There was a problem hiding this comment.
At this juncture I was going to leave all existing packages, and internal references alone, while still replacing the moniker at necessarily non-key intersections.
Primarily just to pare down the count of references
| @@ -36,7 +36,7 @@ | |||
| "atom-select-list": "^0.8.1", | |||
| "autocomplete-atom-api": "https://codeload.github.com/atom/autocomplete-atom-api/legacy.tar.gz/refs/tags/v0.10.7", | |||
There was a problem hiding this comment.
Same note here about rebranding the Repository name. Additionally for all packages pointing to codeload.github.com/atom should these note be changed to pulsar-edit as all original Atom repos have been successfully forked to puslar-edit
| @@ -0,0 +1,40 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
If you like, we have an updated, rebranded, and reworked language version of this bug report template available here, which likely can be copied wholesale as the contents of this document.
| @@ -0,0 +1,40 @@ | |||
| <!-- | |||
|
Since speaking with @Spiker985 previously he is fine with me going ahead and merging recommendations on the Markdown files themselves, so I will clear those out of my requested changes. Otherwise as its been open for nearly a week, and there doesn't seem to be any other issues found how do we feel about merging into main @pulsar-edit/core @pulsar-edit/documentation |
|
How do we feel about merging some JSON data rebranding into this PR, then commit to main? If anyone else wants to go ahead and approve it we could probably commit afterwards |
|
I'm gonna go ahead and merge this into the rebrand branch for But its been up for some time, and while I think there can still be advantages of modifying the JSON and some other aspects I will leave those up to another PR as this one is already large enough. Otherwise as for testing our expected failure rate of 55 Editor Tests and 22 Package Tests this does fall short on some of those. But it looks like this PR was created before those goals were set or expected. Its current stats look like so:
So while on Ubuntu the Editor experiences more errors than we like, on Windows its the exact opposite of what we would expect, so I will merge in hopes these can be ironed out before merging to main. |
Because this branch was originally cherry-picked and it's last commit was 0fdf1ed, it was missing quite a few files from master.
The only merge conflict was
src/context-menu-manager.coffeewhich was deleted from master, and originally had an A[a]tom -> P[p]ulsar rename within one of the comments.All other files were auto-merged together.
Confirmed
yarn install && yarn build && yarn startdid function, and load the editor.