Bundle package-generator
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Sertonix <83883937+Sertonix@users.noreply.github.com>
sertonix
reviewed
Dec 10, 2022
Co-authored-by: Sertonix <83883937+Sertonix@users.noreply.github.com>
|
@sertonix fantastic catch, I've committed your suggestion |
sertonix
reviewed
Dec 10, 2022
| @@ -0,0 +1,3 @@ | |||
| .package-generator .error { | |||
| display: none; | |||
There was a problem hiding this comment.
This is not related to this pull request but this seems like a hack?!
There was a problem hiding this comment.
Yeah does seem a little bit weird, but looks like this is manually changed if needed, they set the display to block when there's actually an error
sertonix
approved these changes
Dec 10, 2022
|
If #209 is merged could you add a |
|
With prior agreement on this direction for the editor, and approval from another dev, I'll go ahead and merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed on Discord, we are okay with integrating more packages with our Bundled Core Packages.
Due to a new PR on
package-generatorthis package has come to my attention as one that may be eligible to bundle.There was an original issue on Atom to do this same thing.
Additionally other than just bundling the package, I've replicated the changes made by @sertonix and added them here, to include their efforts, and properly include them as an author of that PR.
Lastly I ensured to include any PR's that have previously targeted our Bundled PRs.
Checking for changes needed in accordance to:
standardlinter from packages #158packages/*/package.json#157packages/*/package-lock.json#209