Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git tab in binaries #140

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix git tab in binaries #140

merged 1 commit into from
Nov 15, 2022

Conversation

benonymus
Copy link
Contributor

@benonymus benonymus commented Nov 12, 2022 •
edited
Loading

It was discovered that in built binaries the functions of the git integration are not working.

This pr fixes that.

Relevant thread: https://discord.com/channels/992103415163396136/992103415163396139/1040564640062648370

@benonymus benonymus mentioned this pull request Nov 12, 2022
Closed
@benonymus benonymus force-pushed the fix-git-tab-in-binaries branch from fbefbdf to 948091c Compare November 12, 2022 18:35
@jonian
Copy link
Contributor

jonian commented Nov 12, 2022 •
edited
Loading

@mauricioszabo can you merge this, please? It will make my AUR package installation faster. Right now I have to extract app.asar and move github bin files in app.asar.unpacked. Unpacking asar takes some time, actually more than extracting the deb archive. Thanks!

@confused-Techie
Copy link
Member

@mauricioszabo can you merge this, please? It will make my AUR package installation faster. Right now I have to extract app.asar and move github bin files in app.asar.unpacked. Unpacking asar takes some time, actually more than extracting the deb archive. Thanks!

I've enabled tests on this one to get a better look, and in the future might recommend pinging teams rather than individual people to help ensure your pings get seen. We have @pulsar-edit/core, @pulsar-edit/documentation, @pulsar-edit/backend

@jonian
Copy link
Contributor

jonian commented Nov 12, 2022 •
edited
Loading

Thanks @confused-Techie! I don't think this will cause any issues, it just extracts some files from asar. In fact without this, pulsar binaries are broken, since github package does not work.

confused-Techie
confused-Techie approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall to me, tests pass (although don't think they are affected by this change).

But would like to defer to @pulsar-edit/core to review this change. As they are much more familiar with the electron builder process.

@jonian
Copy link
Contributor

jonian commented Nov 15, 2022 •
edited
Loading

@confused-Techie there are other paths that should be extracted from asar as you can see at https://github.com/atom/atom/blob/master/script/lib/package-application.js#L189.

@mauricioszabo mauricioszabo merged commit f5f4c1d into pulsar-edit:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@confused-Techie confused-Techie confused-Techie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benonymus @jonian @confused-Techie @mauricioszabo