Updated README Design #123
Conversation
|
You might want to check #120 because that is already adding, removing and updating the badges. Once we get our actual branding resources in then this will likely all change anyway. |
|
Yeah I agree with @Daeraxa it might be best to wait before we start modifying colours and such. The layout is a great suggestion, and removing duplicates obviously also great. But beyond that the cards are all already being changed, and really I'd think we want the colours to match our branding once we have that rather then least contrast. As always thanks for the contribution, but maybe lets get #120 merged first, if you'd like to contribute on that, then we can modify what that's already doing |
|
With #120 having been merged do we feel this PR is still needed? Or would @ElectronicsArchiver want to rebase, and change the new badges that have been added? |
|
Thanks GitHub for not notifying me at until now . . . |
No worries, but feel free to let me know what you'd like to do on this PR. Again thanks for contributing! |
Guess I can rebase~ |
ElectronicsArchiver
force-pushed
the
master
branch
2 times, most recently
from
e937f66 to
62f666f
Compare
|
@confused-Techie Done |
There was a problem hiding this comment.
This PR looks great, with the changes you've added and referencing how it looks displayed as a ReadMe, looks great to me.
Now of course keep in mind eventually these colours will likely be changed, and we will have to find the best location for the social links to go once a banner is here. But otherwise looks great to me, and I say lets merge this one. If anyone else from @pulsar-edit/documentation wants to take a look first
ElectronicsArchiver
force-pushed
the
master
branch
from
62f666f to
3207740
Compare
|
So I'm looking at this PR and wanting to merge it, but it's showing changes to PPM. Which obviously as this PR is for the readme, we should address before merging. I was wanting to go ahead and get this fixed, which with your permission is something I'll do, unless you'd like to do it yourself. As we haven't come across this issue before, we are trying to determine what exactly needs to be done to get the submodule to match what's present in our repo, but feel free to read our discussion on it, to find the right command to run, or otherwise let me know if it's fine to try myself. Thanks again for your contribution! |
|
Hi folks, I do have a commit that should resolve the ppm situation: master...DeeDeeG:pulsar:erpm-ppm-fix (be968b7). So this is technically figured out, just want to make sure we communicate properly about how to get it in as a part of this PR. (See @confused-Techie's comment above.) |
|
@confused-Techie I don't have Discord, can't access the discussion even if I wanted. |
|
@DeeDeeG looks like the best move might be to commit those changes you made if you wouldn't mind. Thanks for letting us get this sorted @ElectronicsArchiver |
|
Thanks to the work of @DeeDeeG this PR is all cleaned up, and I'll go ahead and merge. Thanks again for the contributions! |
Please Check The Preview
I adjusted my design a bit to be easier on the eyes~
Removed old, duplicate & unused badge declaration.
Adjusted badge colors to
reduce the contrast between the badge title and content.
to increase the constrast between background and badge title.
to comply with the given color palette.
Adjusted layout to be more inline with the common, user expected,
social media at the top navigation belowconcept.Release Notes
N/A
If you have any questions.
In case you do not agree with some of the changes made in this PR,
please first let me know about them, before disregarding it entirely so
we can possibly find a middle ground and have it not go to waste.
No, I'm not a robot.
Yes, you are not the first.
I just made a PR template.