Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: Update for 1.122.0 #1112

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Changelog: Update for 1.122.0 #1112

merged 1 commit into from
Oct 18, 2024

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Oct 18, 2024

Adding the changelog items for PRs landed in pulsar-edit/pulsar repo since Regular release 1.121.0 went out.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not doing this myself like usual.
But this looks fantastic, and matches our existing style.

I've rerun the failing spec just for some green CI, but it really doesn't matter here as these changes cannot meaningfully effect the application.

@confused-Techie
Copy link
Member

Even with this failing for some odd reason, I know it's not due to the changes here, so think we should be good to go ahead and merge, assuming this is a flaky test acting up.

@confused-Techie confused-Techie merged commit bce7221 into master Oct 18, 2024
101 of 103 checks passed
@DeeDeeG DeeDeeG deleted the changelog-1.122.0 branch October 21, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants