Decaf Source #84
Decaf Source #84
Conversation
TBH Was worried to touch to much in this file considering how important and dense it is. So decaf work was extremely light here
Originally I was matching indentation of output strings compared to the CoffeeScript source, but I've learned that indentation is actually ignored, so resolving
This reverts commit a3cd921.
|
So knowing the tendency of decaf PRs to properly have a review, I may just go ahead and trust the tests on this one, since there are a few other changes I'd actually like to make beyond just decaf work. So knowing that all tests are passing here except "Windows - NodeJS 16" and "Windows - NodeJS 18" (Which are the fault of windows being unable to build the native modules we use after our upgrade to node-gyp, which should be solved once we can switch over to But this means the failures there are excepted, and otherwise all tests are passing totally fine. So I'll go ahead and change the target branch to |
This PR decafs the entire source of PPM. Following with our current guidelines of initially comparing against a machine decaf branch. Once ready to merge, the target branch will be changed to
master. This is done to make review possible, as there's something to compare changes against.The vast majority of this decaf is rather light, this is done on purpose, since I'd rather not break anything, especially considering that the vast majority of modified values are passed around rather than originating in any particular function.