-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, since this is still a direct dependency of the core, but is not bundled within.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, somehow missed the link it was resolving to. Updated some quick comments for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright merged the issues I found, may want to look at later replacing ISSUE_TEMPLATE.md
to mirror what we have on our .github/BUG_REPORT.md
But otherwise looks great, and we should be able to merge if someone from the @pulsar-edit/documentation wants to take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM?
CONTRIBUTING.md
Outdated
@@ -1 +1 @@ | |||
See the [contributing guide](https://github.com/pulsar-edit/.github/blob/main/CONTRIBUTING.md) | |||
See the [Pulsar contributing guide](https://github.com/pulsar-edit/.github/blob/main/CONTRIBUTING.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the [Pulsar contributing guide](https://github.com/pulsar-edit/.github/blob/main/CONTRIBUTING.md) | |
See how you can contribute [here](https://github.com/pulsar-edit/.github/blob/main/CONTRIBUTING.md) |
I originally removed the word Atom/Pulsar as it's redundant. However I think we should just adjust all of these to the above verbiage. What do we think @pulsar-edit/documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changed verbiage is actually very nice, and allows anyone after us to avoid having endless rebranding to do. Personally I am totally fine with it, and would be happy to see it rolled out wherever possible, as its simpler and more inviting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this new wording!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After getting suggestions on the server, I'll put this up as a change to the link placement.
Can be discarded if the repo is no longer in use