-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace references to master branch #2210
Conversation
Is there something specific that I've happened to miss that broke the checks, or was it because of the tree I used? |
Just seems If you run |
On it, I'll also add a |
Sorry, but there's more references to Also good call on the changelog entry, this next release is going to break a lot of things... and this change will probably make that breakage even worse 😆 I'm on the fence about putting this change under documentation since while these changes are in the docs, for users any CI, random scripts, etc. references to |
Sure thing, I was actually just very hesitant to fix them. I'll see what I can do and get back to you if there's anything wrong. I'll note that I'm also going to change this line, which is a reference to Line 77 in 1bedc17
I don't think it will, it's mostly just documentation-related changes. Unless if you're referring to the transition from the |
Additional note: I frankly have no idea why the CI check is freaking out. The test passes on my machine, can't see any tab/space-related sort of difference. |
I added an additional note regarding some source code changes, but I didn't see the changes as substantial enough to move the log away from the Moreover:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Congrats on your first contribution to Black.
I'll commit my suggestion myself so you don't have to spend more time on this. I'll merge once CI passes.
1. Use the online formatter at <https://black.vercel.app/?version=main>, which will use | ||
the latest main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the Black Playground breaks on this version value, I'll see I can submit a PR over there later today so this doesn't stay broken.
We're moving away from GitHub as a documentation host to only RTD because it's makes our lives easier creating good docs. I know this link is dead right now, but it won't be once we release a new version with the documentation reorganization changes (which should be soon!).
I may or may not have forgotten about this PR... whoops! Clicking the magical green button now. |
master
underCHANGES.md
.https://github.com/panos/black/blob/b59c54ad75f7f6c11c791a03b5fe84ab2b52f37c/.flake8#L4