Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for .NET 4.6.1 #141

Merged
merged 1 commit into from
Dec 9, 2015
Merged

adding support for .NET 4.6.1 #141

merged 1 commit into from
Dec 9, 2015

Conversation

jdaigle
Copy link
Contributor

@jdaigle jdaigle commented Dec 8, 2015

No description provided.

@gep13
Copy link
Member

gep13 commented Dec 8, 2015

Thanks for your contribution! I will get this pulled into a release over the next couple days. Just waiting for the permissions needed to push the package to nuget.org and chocolatey.org. Thanks!

damianh added a commit that referenced this pull request Dec 9, 2015
adding support for .NET 4.6.1
@damianh damianh merged commit fbf9386 into psake:master Dec 9, 2015
@damianh
Copy link
Contributor

damianh commented Dec 12, 2015

+1
On 8 Dec 2015 8:51 pm, "Gary Ewan Park" notifications@github.com wrote:

Thanks for your contribution! I will get this pulled into a release over
the next couple days. Just waiting for the permissions needed to push the
package to nuget.org and chocolatey.org. Thanks!


Reply to this email directly or view it on GitHub
#141 (comment).

@gep13
Copy link
Member

gep13 commented Dec 12, 2015

@damianh I am good to push this tonight, but I am still considered about the failing test that I am seeing. Any thoughts on why this is failing for me. Is this environment specific do you think?

@damianh
Copy link
Contributor

damianh commented Dec 12, 2015

sorry lad no clue
On 12 Dec 2015 8:13 pm, "Gary Ewan Park" notifications@github.com wrote:

@damianh https://github.com/damianh I am good to push this tonight, but
I am still considered about the failing test that I am seeing. Any thoughts
on why this is failing for me. Is this environment specific do you think?


Reply to this email directly or view it on GitHub
#141 (comment).

@damianh
Copy link
Contributor

damianh commented Dec 12, 2015

push it anyway
On 12 Dec 2015 9:02 pm, "Damian Hickey" dhickey@gmail.com wrote:

sorry lad no clue
On 12 Dec 2015 8:13 pm, "Gary Ewan Park" notifications@github.com wrote:

@damianh https://github.com/damianh I am good to push this tonight,
but I am still considered about the failing test that I am seeing. Any
thoughts on why this is failing for me. Is this environment specific do you
think?


Reply to this email directly or view it on GitHub
#141 (comment).

@nightroman
Copy link
Contributor

Assert ($output -NotLike "14.0") '$output should contain 14.0'

Should it be -like?

@gep13 gep13 modified the milestone: 4.5.0 Jan 15, 2016
@gep13 gep13 added the Feature label Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants