Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles and styles 4.0.0 #282

Closed
bdon opened this issue Aug 12, 2024 · 8 comments
Closed

Tiles and styles 4.0.0 #282

bdon opened this issue Aug 12, 2024 · 8 comments

Comments

@bdon
Copy link
Member

bdon commented Aug 12, 2024

DESCRIPTION

Breaking changes:

  • drop pmap: prefixes from tag names to align with tilezen.
  • Remove deprecated OSM tags in favor of kind
  • remove physical_point, natural and physical_line layers to align with tilezen. features go into the landuse or water, poi or earth layers.

Resolve other issues:

@nvkelso @wipfli

bdon added a commit that referenced this issue Aug 17, 2024
* remove deprecated non-kind tags

* tiles 4.0.0-alpha.1
@wipfli
Copy link
Collaborator

wipfli commented Aug 18, 2024

For v4 I would like to segment names by script #273 and remove the pgf: prefix (store pgf encoded strings by default, have bare unicode in other property).

bdon added a commit that referenced this issue Aug 23, 2024
* Places: don't use Natural Earth at low zooms [#256, #282]

* bump tiles version to 4.0.0-alpha.3
bdon added a commit that referenced this issue Sep 16, 2024
@bdon
Copy link
Member Author

bdon commented Sep 16, 2024

@nvkelso we also need to collapse roads > medium_road into major_road (with appropriate kind_detail)

@nvkelso
Copy link
Collaborator

nvkelso commented Sep 17, 2024

While Tilezen 1.x series doesn't have a separate layer for OSM natural tagged features, in v2 we said those should go into a landcover layer in tilezen/vector-datasource#2025 and related #154.

Unclear if there should also be a structures layer & etc tilezen/vector-datasource#2026.

@nvkelso
Copy link
Collaborator

nvkelso commented Sep 17, 2024

remove physical_point, natural and physical_line layers to align with tilezen. features go into the landuse or water, poi or earth layers.

Are you ok with mixed geometry types in the MVT layers like Tilezen had?

@nvkelso
Copy link
Collaborator

nvkelso commented Sep 17, 2024

Remove deprecated OSM tags in favor of kind

Need to ensure kind_detail captures the appropriate raw OSM values. I think it does today, but it's the combo of kind and kind_detail that makes dropping the raw tags possible.

@bdon
Copy link
Member Author

bdon commented Sep 17, 2024

Are you ok with mixed geometry types in the MVT layers like Tilezen had?

We need to add geometry type filters to the style.

While Tilezen 1.x series doesn't have a separate layer for OSM natural tagged features, in v2 we said those should go into a landcover layer in tilezen/vector-datasource#2025 and related #154.

I am already separating out daylight landcover into a new landcover that is not part of Tilezen.

Plan is to keep OSM landcover in landuse for Tangram preservation reasons until 5.0.

bdon added a commit that referenced this issue Sep 17, 2024
bdon added a commit that referenced this issue Sep 17, 2024
* add show debug boxes to viewer [#286]

* freeze tileset version [#282]
bdon added a commit that referenced this issue Sep 20, 2024
bdon added a commit that referenced this issue Sep 20, 2024
* breaking change: remove pmap: prefixes from tiles.
* breaking change: remove physical_point, natural and physical_line layers.
* move features into landuse, water, pois and earth.
bdon added a commit that referenced this issue Sep 20, 2024
* breaking change: remove pmap: prefixes from tiles.
* breaking change: remove physical_point, natural and physical_line layers.
* move features into landuse, water, pois and earth.
@bdon
Copy link
Member Author

bdon commented Sep 20, 2024

breaking changes to tiles merged in 55d0df2

will follow up with style changes

bdon added a commit that referenced this issue Sep 20, 2024
* remove pmap prefixes from style and refactor layers (breaking change)
* unfreeze map viewer version
* upgrade viewer to pmtiles 3.1.0
bdon added a commit that referenced this issue Sep 20, 2024
* Styles 4.0.0-alpha.1 [#282]

* remove pmap prefixes from style and refactor layers (breaking change)
* unfreeze map viewer version
* upgrade viewer to pmtiles 3.1.0
@bdon
Copy link
Member Author

bdon commented Sep 20, 2024

Both tiles and styles have been merged now.

@bdon bdon closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants