Split the code generators for .upb and .upbdefs. #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before there was a single code generator that generated both .upb and .upbdefs, even though they are generated by different rules. This worked fine as long as the codegen steps were sandboxed, but if not it led to build errors. Fixes https://github.com/protocolbuffers/upb/issues/354.
haberman
force-pushed
the
codegen-uniquefiles
branch
from
1805fc7 to
7a54a5f
Compare
aherrmann-da
pushed a commit
to digital-asset/daml
that referenced
this pull request
Feb 2, 2021
To include grpc/grpc#24953 and protocolbuffers/upb#356 which fix https://github.com/protocolbuffers/upb/issues/354. The issue manifested on Windows CI with errors of the form ``` bazel-out/x64_windows-opt/bin/external/com_google_protobuf/google/protobuf/descriptor.upb.c: Permission denied ``` See https://dev.azure.com/digitalasset/daml/_build/results?buildId=68545
aherrmann-da
pushed a commit
to digital-asset/daml
that referenced
this pull request
Feb 2, 2021
To include grpc/grpc#24953 and protocolbuffers/upb#356 which fix https://github.com/protocolbuffers/upb/issues/354. The issue manifested on Windows CI with errors of the form ``` bazel-out/x64_windows-opt/bin/external/com_google_protobuf/google/protobuf/descriptor.upb.c: Permission denied ``` See https://dev.azure.com/digitalasset/daml/_build/results?buildId=68545 changelog_begin changelog_end
aherrmann-da
pushed a commit
to digital-asset/daml
that referenced
this pull request
Feb 2, 2021
To include grpc/grpc#24953 and protocolbuffers/upb#356 which fix https://github.com/protocolbuffers/upb/issues/354. The issue manifested on Windows CI with errors of the form ``` bazel-out/x64_windows-opt/bin/external/com_google_protobuf/google/protobuf/descriptor.upb.c: Permission denied ``` See https://dev.azure.com/digitalasset/daml/_build/results?buildId=68545 changelog_begin changelog_end
aherrmann-da
pushed a commit
to digital-asset/daml
that referenced
this pull request
Feb 2, 2021
To include grpc/grpc#24953 and protocolbuffers/upb#356 which fix https://github.com/protocolbuffers/upb/issues/354. The issue manifested on Windows CI with errors of the form ``` bazel-out/x64_windows-opt/bin/external/com_google_protobuf/google/protobuf/descriptor.upb.c: Permission denied ``` See https://dev.azure.com/digitalasset/daml/_build/results?buildId=68545 changelog_begin changelog_end
6 tasks
aherrmann-da
added a commit
to digital-asset/daml
that referenced
this pull request
Feb 3, 2021
To include grpc/grpc#24953 and protocolbuffers/upb#356 which fix https://github.com/protocolbuffers/upb/issues/354. The issue manifested on Windows CI with errors of the form ``` bazel-out/x64_windows-opt/bin/external/com_google_protobuf/google/protobuf/descriptor.upb.c: Permission denied ``` See https://dev.azure.com/digitalasset/daml/_build/results?buildId=68545 changelog_begin changelog_end Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before there was a single code generator that generated both
.upb and .upbdefs, even though they are generated by different
rules. This worked fine as long as the codegen steps were
sandboxed, but if not it led to build errors.
Fixes https://github.com/protocolbuffers/upb/issues/354.
cc @veblush