Updated upb to pick up several bugfixes #7740
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
LGTM |
* Updated upb to pick up several bugfixes. This fixes most conformance failures. * Updated golden file, now that we are serializing as packed by default. * Set "packed" properly: it is on by default for packable fields in proto3. * Updated failure list for PHP now that we properly respect "packed". * Temporarily disable encode_decode_test Co-authored-by: Joshua Haberman <jhaberman@gmail.com>
* Updated upb to pick up several bugfixes. This fixes most conformance failures. * Updated golden file, now that we are serializing as packed by default. * Set "packed" properly: it is on by default for packable fields in proto3. * Updated failure list for PHP now that we properly respect "packed". * Temporarily disable encode_decode_test Co-authored-by: Joshua Haberman <jhaberman@gmail.com>
* Updated upb to pick up several bugfixes. This fixes most conformance failures. * Updated golden file, now that we are serializing as packed by default. * Set "packed" properly: it is on by default for packable fields in proto3. * Updated failure list for PHP now that we properly respect "packed". * Temporarily disable encode_decode_test Co-authored-by: Joshua Haberman <jhaberman@gmail.com>
Copied from #7734
Temporarily disable encode_decode_test.php.
In 4.0.0-rc1, repeated primitive field encoding is changed to packed, which is a bug fix. However, this fails the compatibility test which hard coded old encoding. Will reenable the test after making a release. After the version bump, the compatibility test will use the updated test code.