[PHP] Updated upb to pick up several bugfixes. #7734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #7732 |
|
There is a goldenfile test failure. I am guessing this is because upb now properly respects the proto3 semantics of packed serialization by default. |
|
https://github.com/protocolbuffers/protobuf/pull/7588/files |
|
Hmm, I updated the golden file test, but the golden file compatibility test is broken. The old test expects that the field is encoded as not packed. @TeBoring could you figure out a solution for this? It seems we will need to change or patch the compatibility tests. |
|
Continued in #7740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most of PHP's remaining conformance failures.