Fix Python 3.4 cpp implementation #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Looks like Travis is failing though? |
|
@haberman Ugh, sorry. I guessed that Python 3.4 would be installed on the Travis machines, but turns out I guessed wrong. Looks like everything is passing now that it's installed from the ppa. |
|
@haberman I just rebased this to pick up the latest upstream changes. After resolving conflicts it looks like everything is still passing. Let me know if any other work is needed prior to merging. |
| @@ -113,12 +113,14 @@ build_javanano_oracle7() { | |||
|
|
|||
| internal_install_python_deps() { | |||
| sudo pip install tox | |||
| # Only install Python2.6 on Linux. | |||
| # Only install Python2.6/3.3 on Linux. | |||
|
Besides that one comment change, looks good to me. Thanks! |
Fixes the ScalarMapContainer/MessageMapContainer implementations on Python 3.4, by dynamically allocating their PyTypeObjects using PyType_FromSpecWithBases, instead of statically allocating them. This is necessary because Python 3.4+ disallows statically allocating a class with a dynamically allocated parent. Signed-off-by: Dan O'Reilly <oreilldf@gmail.com>
|
@haberman Should be good now. |
haberman
added a commit
that referenced
this pull request
Sep 4, 2015
Fix Python 3.4 cpp implementation
|
Thanks! |
adellahlou
pushed a commit
to adellahlou/protobuf
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ScalarMapContainer/MessageMapContainer implementations on
Python 3.4, by dynamically allocating their PyTypeObjects using
PyType_FromSpecWithBases, instead of statically allocating them. This is
necessary because Python 3.4+ disallows statically allocating a class
with a dynamically allocated parent.
Signed-off-by: Dan O'Reilly oreilldf@gmail.com