Down integrate. Generate a package name suffix ".nano" for nano messages #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introducing an option javanano_use_deprecated_package to allow users to disable the suffix
zsurocking
changed the title
Also introducing an option javanano_use_deprecated_package to allow users to disable the suffix
| @@ -30,16 +30,16 @@ | |||
|
|
|||
| package com.google.protobuf.nano; | |||
|
|
|||
| import com.google.protobuf.nano.MapTestProto.TestMap; | |||
| import com.google.protobuf.nano.MapTestProto.nano.TestMap; | |||
There was a problem hiding this comment.
Can you try com.google.protobuf.nano.nano.MapTestProto.TestMap
|
@TeBoring PTAL |
|
LGTM |
TeBoring
added a commit
that referenced
this pull request
Aug 7, 2015
Down integrate. Generate a package name suffix ".nano" for nano messages
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
…#645) Export proto.Properties.{MapKeyProp, MapValProp} so that jsonpb can pass the appropriate type information downstream.
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Down integrate. Generate a package name suffix ".nano" for nano messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introducing an option javanano_use_deprecated_package to allow users to disable the suffix