Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary conformance test for default repeated fields #6440

Merged
merged 10 commits into from
Jul 26, 2019
Merged

Add binary conformance test for default repeated fields #6440

merged 10 commits into from
Jul 26, 2019

Conversation

TeBoring
Copy link
Contributor

  1. Both packed and unpacked encoding should be accepted for parsing.
  2. Encode should follow the default way for the syntax.

@TeBoring
Add binary conformance test for default repeated fields
830a7de 
1) Both packed and unpacked encoding should be accepted for parsing.
2) Encode should follow the default way for the syntax.
@TeBoring TeBoring requested a review from acozzette July 25, 2019 00:35
TeBoring added 2 commits July 25, 2019 14:53
@TeBoring
Use binary format to specify expected value
fdc6778 
Text format cannot distinguish whether repeated field is packed or not.
@TeBoring
Change method name from ToHexString to ToOctString
95dcb76
@TeBoring TeBoring merged commit a9bb656 into protocolbuffers:master Jul 26, 2019
@TeBoring TeBoring deleted the conformance-packed branch July 26, 2019 20:29
This was referenced Aug 26, 2019
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozzette acozzette acozzette approved these changes

Assignees

@acozzette acozzette

Labels
cla: yes conformance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TeBoring @acozzette @googlebot @protobuf-kokoro