Add csharp compatibility tests between last released and the current version #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeBoring
reviewed
Jul 20, 2019
tests.sh
Outdated
| @@ -147,6 +147,9 @@ build_csharp() { | |||
|
|
|||
| # Run csharp compatibility test between 3.0.0 and the current version. | |||
| csharp/compatibility_tests/v3.0.0/test.sh 3.0.0 | |||
|
|
|||
| # Run csharp compatibility test between 3.7.0 and the curretn version. | |||
| csharp/compatibility_tests/v3.0.0/test.sh 3.7.0 | |||
There was a problem hiding this comment.
How about just update 3.0.0 on line 149 to 3.7.0?
There was a problem hiding this comment.
I'd prefer to keep two compatibility tests: one between a fixed very old version with current and another is last released version with current.
Have changed C# to use last released version instead of 3.7.0 here. Will try to change other languages later
anandolee
changed the title
anandolee
changed the title
TeBoring
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6379