New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the closure compiler version #5955

Merged

4 commits merged into protocolbuffers:master from unknown repository

Mar 28, 2019

ghost commented Mar 26, 2019

No description provided.


          Upgrade the closure compiler version

4182c8b

googlebot added the cla: yes label

ghost requested a review from acozzette

March 26, 2019 23:45

ghost marked this pull request as ready for review

March 26, 2019 23:45

ghost assigned acozzette

acozzette added the kokoro:run label

kokoro-team removed the kokoro:run label

acozzette approved these changes

View reviewed changes

ghost added kokoro:run and removed kokoro:run labels

kokoro-team removed the kokoro:force-run label

Hao Nguyen added 3 commits

March 27, 2019 15:54


          Merge https://github.com/protocolbuffers/protobuf into js

8046e0f


          Update Dockerfile for JavaScript. The old one is using an npm that is…

e66e603

… too outdated


          Revert unintended changes

f95862e

ghost added the kokoro:force-run label

kokoro-team removed the kokoro:force-run label

Author

ghost commented Mar 28, 2019

PTAL. Turned out it was the Docker's npm was too old after all. Created a new Docker file for Javascript and it is now passing.

Member

acozzette commented Mar 28, 2019

LGTM

ghost merged commit 3efc3fd into protocolbuffers:master

chenchihhung commented Mar 28, 2019 via email

您好取得 Android 版 Outlook<https://aka.ms/ghei36>

________________________________ From: Hao Nguyen <notifications@github.com> Sent: Friday, March 29, 2019 12:55:49 AM To: protocolbuffers/protobuf Cc: chenchihhung; Manual Subject: Re: [protocolbuffers/protobuf] Upgrade the closure compiler version (#5955) Merged #5955<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprotocolbuffers%2Fprotobuf%2Fpull%2F5955&data=02%7C01%7C%7C4867f4cf7dde465239c908d6b39e3b35%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636893889504686303&sdata=Bz3daVeg8%2Ff3VguErr%2FIlfeAm54PwhpwTSUQe1Az7q4%3D&reserved=0> into master. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprotocolbuffers%2Fprotobuf%2Fpull%2F5955%23event-2236949117&data=02%7C01%7C%7C4867f4cf7dde465239c908d6b39e3b35%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636893889504696315&sdata=PFJAHZOECQsFQVDHfrY67L%2FIMMPPQ0%2BbJX8Ttaxv1EI%3D&reserved=0>, or mute the thread<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAuv7OXToAYsS6RXtqC5L3rxgd5ysmHVHks5vbPQVgaJpZM4cMoux&data=02%7C01%7C%7C4867f4cf7dde465239c908d6b39e3b35%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636893889504706314&sdata=DM3MXXmm5WtSfuVrsiMmCwQffhUK8IJmZ7H5GbtWLow%3D&reserved=0>.

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels