Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rc version in update_version.py #5750

Merged
3 commits merged into from Feb 20, 2019
Merged

Support rc version in update_version.py #5750

3 commits merged into from Feb 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 19, 2019

No description provided.

@ghost ghost assigned TeBoring Feb 19, 2019
@ghost ghost requested a review from TeBoring February 19, 2019 21:58
@ghost ghost mentioned this pull request Feb 19, 2019
update_version.py Outdated Show resolved Hide resolved
update_version.py Outdated Show resolved Hide resolved
update_version.py Outdated Show resolved Hide resolved
@TeBoring
Copy link
Contributor

Also added script for php/ext/google/protobuf/protobuf.h and java/bom/pom.xml in #5749 . They also need this change.

@ghost
Copy link
Author

ghost commented Feb 20, 2019

Update version for php/ext/google/protobuf/protobuf.h. java/bom/pom.xml is already being updated so no change there.

@ghost ghost merged commit e22907f into protocolbuffers:master Feb 20, 2019
@ghost ghost deleted the version branch February 20, 2019 19:25
TeBoring pushed a commit to TeBoring/protobuf that referenced this pull request Feb 22, 2019
* Support rc version in update_version.py
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants