Fix Ruby module name generation when the ruby_package option is used #5735
Conversation
| @@ -2,6 +2,6 @@ syntax = "proto3"; | |||
|
|
|||
| package foo_bar; | |||
|
|
|||
| option ruby_package = "A.B"; | |||
| option ruby_package = "A::B"; | |||
There was a problem hiding this comment.
Does this change the existing API?
There was a problem hiding this comment.
Sort of, but I think the original implementation was incorrect.
In all other languages, the package options follow the same format as the language and :: is the correct delimiter in Ruby.
For example, this proto has a bunch of language package options defined: https://github.com/googleapis/googleapis/blob/1a4f0f12777dc2f8bf2c2ce84438329639c75e29/google/pubsub/v1/pubsub.proto#L33
There was a problem hiding this comment.
Will this break existing users?
If so, can we support both for now?
There was a problem hiding this comment.
Maybe in protoc, we can throw warning if "A.B" is used.
There was a problem hiding this comment.
Supporting both options sounds like a good solution. I've updated it to work with both and issue a warning if the A.B form is used instead of A::B.
… option is used (protocolbuffers#5735)"" This reverts commit bb211e8.
…rotocolbuffers#5735) * fix module name generation and add tests * fix existing tests * support both package name styles
…is used (protocolbuffers#5735)" This reverts commit 9638dcc.
…(again) (protocolbuffers#5794) * Revert "Revert "Fix Ruby module name generation when the ruby_package option is used (protocolbuffers#5735)"" This reverts commit bb211e8. * add new files to Makefile.am
Resolves #5584 by ensure that the Ruby module name is always generated in the following format:
instead of:
I also added some tests for the
ruby_packageoption.