Remove "using namespace std" from stubs/common.h #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfxyjwf
approved these changes
Apr 26, 2017
src/google/protobuf/stubs/common.h
Outdated
| @@ -220,7 +225,13 @@ class FatalException : public std::exception { | |||
|
|
|||
| // This is at the end of the file instead of the beginning to work around a bug | |||
| // in some versions of MSVC. | |||
| using namespace std; // Don't do this at home, kids. | |||
| using std::istream; | |||
There was a problem hiding this comment.
Add a TODO here? I think we want to get rid of these using statements in public header files as well.
There was a problem hiding this comment.
Done, I've added a TODO there.
acozzette
force-pushed
the
using-namespace-std
branch
from
2c990e7 to
20d1e15
Compare
This prevents the contents of the std namespace from being effectively pulled into the top-level namespace in all translation units that include common.h. I left in individual using statements for a few common things like std::set and std::map, because it did not seem worth going through the churn of updating the whole codebase to fix those right now.
acozzette
force-pushed
the
using-namespace-std
branch
from
20d1e15 to
7c76ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the contents of the std namespace from being effectively
pulled into the top-level namespace in all translation units that
include common.h. I left in individual using statements for a few common
things like std::set and std::map, because it did not seem worth going
through the churn of updating the whole codebase to fix those right now.