Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial check in of PHP implementation #2052

Merged
merged 1 commit into from
Sep 15, 2016
Merged

Initial check in of PHP implementation #2052

merged 1 commit into from
Sep 15, 2016

Conversation

TeBoring
Copy link
Contributor

@TeBoring TeBoring commented Sep 1, 2016

This pull request includes two implementation: C extension and PHP
package. Both implementations support encode/decode of singular,
repeated and map fields. Oneof support will be added in future pull
requests.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@TeBoring
Copy link
Contributor Author

@xfxyjwf

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Sep 15, 2016

ok to test

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Sep 15, 2016

Can you update the link in the top level README.md file for php?

xfxyjwf
xfxyjwf reviewed Sep 15, 2016
View reviewed changes
composer.json
@@ -0,0 +1,24 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file and does it have to be in the top level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed for using pure PHP runtime. Basically it describes the PHP runtime package like Protobuf.spec for objc. It has to be on the top level to be correctly pulled by the central PHP repository.

@TeBoring
Check in php implementation.
344ac6d 
This pull request includes two implementation: C extension and PHP
package. Both implementations support encode/decode of singular,
repeated and map fields.
@TeBoring TeBoring merged commit e0e5466 into protocolbuffers:master Sep 15, 2016
TeBoring added a commit that referenced this pull request Sep 15, 2016
@TeBoring
Check in php implementation. (#2052)
a13cdf4 
This pull request includes two implementation: C extension and PHP
package. Both implementations support encode/decode of singular,
repeated and map fields.
@pmbethe09
Copy link

This PR broke the bazel BUILD file's ability to run protoc
-- still compiles, but then bazel-bin/protoc fails with:
dyld: Symbol not found: __ZTVN6google8protobuf8compiler3php9GeneratorE
Referenced from: bin/external/com_google_protobuf/protoc
Expected in: flat namespace

git bisect start HEAD HEAD~100
git bisect run bash -c "bazel build :protoc && bazel-bin/protoc --cpp_out=/tmp src/google/protobuf/any.proto || exit 1"

e0e5466 is the first bad commit

Fix: just need to add
src/google/protobuf/compiler/php/php_generator.cc
to the "protoc_lib" target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xfxyjwf xfxyjwf xfxyjwf approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TeBoring @grpc-kokoro @xfxyjwf @pmbethe09 @googlebot