Fix sign-comparison warnings and add a test for that. #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc build treates them as errors and such issues (protobuf change breaks grpc) has been reported repeatedly. For example: protocolbuffers#1813 Change-Id: I077c4557cf3effd5195f88802c38999b884edc30
|
@pherl to review |
| @@ -122,7 +124,6 @@ nobase_include_HEADERS = \ | |||
| google/protobuf/reflection.h \ | |||
| google/protobuf/reflection_ops.h \ | |||
| google/protobuf/repeated_field.h \ | |||
| google/protobuf/repeated_field_reflection.h \ | |||
There was a problem hiding this comment.
It's deleted internally, but the deletion is lost from internal to opensource integration. See http://cl/71942508
There was a problem hiding this comment.
Ops, wrong cl number. Should be this one: http://cl/86669259
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1813
Also added a test to ensure public header files and protobuf generated code doesn't have these warnings. This test doesn't cover protobuf's own implementation code. We may want to update all of protobuf's code to be free of this warning in the future but right now there are just too many of them and require more work to cleanup.