Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the parsing of the proto-framework map file. #1828

Merged
merged 1 commit into from
Jul 22, 2016
Merged

Fixes the parsing of the proto-framework map file. #1828

merged 1 commit into from
Jul 22, 2016

Conversation

sergiocampama
Copy link
Contributor

  • Fixes memory issue where the pointer to the StringPiece would be allocated on the stack, and would mangle the output.
  • Fixes length of the file name when parsing the comma separated files.

@sergiocampama
Fixes the parsing of the proto-framework map file.
2ff9349 
 - Fixes memory issue where the pointer to the StringPiece would be allocated on the stack, and would mangle the output.
 - Fixes length of the file name when parsing the comma separated files.
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@sergiocampama
Copy link
Contributor Author

Fixes #1826

@sergiocampama
Copy link
Contributor Author

@thomasvl FYI

@justinseanmartin
Copy link

LGTM, thanks

@dmaclach
Copy link
Contributor

LGTM

@xfxyjwf xfxyjwf merged commit de5236d into protocolbuffers:master Jul 22, 2016
@sergiocampama sergiocampama deleted the framework branch July 23, 2016 22:09
@assaframan assaframan mentioned this pull request May 13, 2022
Open
@assaframan assaframan mentioned this pull request Oct 18, 2022
Open
@assaframan assaframan mentioned this pull request Nov 25, 2023
Open
@assaframan assaframan mentioned this pull request Apr 16, 2024
Open
@assaframan assaframan mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sergiocampama @grpc-kokoro @justinseanmartin @dmaclach @googlebot @xfxyjwf