Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: encode and freeze strings when the are assigned or decoded. #1821

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Ruby: encode and freeze strings when the are assigned or decoded. #1821

merged 2 commits into from
Jul 25, 2016

Conversation

haberman
Copy link
Member

Review to @raggi.

raggi
raggi reviewed Jul 21, 2016
View reviewed changes
ruby/ext/google/protobuf_c/upb.c
p->top--;
upb_sink_endstr(&p->top->sink, sel);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks unrelated, though I might be missing something?

@raggi
Copy link

raggi commented Jul 21, 2016

LGTM 👍

@haberman haberman merged commit 44bd6bd into protocolbuffers:master Jul 25, 2016
@haberman haberman deleted the rubyfreezestr branch January 2, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haberman @raggi @googlebot