Make C++ code generation of string oneof field compatible with C++11 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
| printer->Print("const "); | ||
| } | ||
| field_generators_.get(field).GeneratePrivateMembers(printer); | ||
| } | ||
| } | ||
|
|
||
| printer->Print("}* $name$_default_oneof_instance_ = NULL;\n", | ||
| printer->Print("} const* $name$_default_oneof_instance_ = NULL;\n", |
There was a problem hiding this comment.
It's to retain constness of the generated string fields.
I wondered why the original code attributed const to string fields as well as
to message fields.
And it seemed to me it was to prevent the other part of the generated code
from calling non-const methods of those supposed-to-be-immune default instances'
fields by mistake.
There was a problem hiding this comment.
Adding "const" here forces the initialization code of this struct to do "const_cast" everywhere. Doesn't seem to be a win to me. Can you remove this "const" and also these "const_cast"s?
Preprocessor token right after string literal without whitespace results in parse failure in C++11.
string oneof field was generated into "const ArenaStringPtr" field inside "default_oneof_instance_" struct (of name "<class name>OneofInstance"). On the other hand, in C++11, const field of type with trivial default constructor causes enclosing type's implicit default constructor to be deleted. Since ArenaStringPtr has tirvial default constructor, this caused default constructor of "default_oneof_instance_" struct to be deleted, making the constructor call inside generated code invalid and fail to compile.
|
To be clear, first two commits are unchanged and the third commit is modified according to your request. |
xfxyjwf
added a commit
that referenced
this pull request
Dec 12, 2014
Make C++ code generation of string oneof field compatible with C++11
TeBoring
pushed a commit
to TeBoring/protobuf
that referenced
this pull request
Jan 19, 2019
Support json parsing for wrapper values
yordis
pushed a commit
to yordis/protobuf
that referenced
this pull request
Dec 8, 2024
Groups are a deprecated feature, only available in proto2. Now, when an incoming payload eventually contains a group, the decoder no longer crashes, it will skip ahead until the group is over and read the remaining fields normally. https://developers.google.com/protocol-buffers/docs/proto#groups https://developers.google.com/protocol-buffers/docs/reference/proto2-spec#group_field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't introduce any C++11 specific feature, but only fixes the behavior with C++11 so that it works fine in the same way as with C++03.
You can reproduce the "problem" by
make checkconfigured withCXXFLAGS=-std=c++11.Applying first commit will reveal the
oneofpart.Tested with clang 3.5.0 and gcc 4.9.2 with and without
-std=c++11.