Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #943

Merged
merged 16 commits into from
Apr 20, 2016
Merged

Upgrade dependencies #943

merged 16 commits into from
Apr 20, 2016

Conversation

dereklieu
Copy link
Member

Includes #929 and #938
Needed to make a new PR because the history got all weird after #942.

I also snuck in a fix for #939.

As far as styling goes, it looks like yaml files look a bit different. The newer version of CodeMirror is applying a class that it didn't previously, which is affecting the custom theme we're using. The other languages I looked at seemed to match up, so I'll try to find time to look at this but don't consider it to be a show-stopper.

screen shot 2016-04-19 at 6 16 44 pm
Old on left, new on right

@dereklieu
Copy link
Member Author

I've also updated our test libraries and tied test libraries with the ones in node_modules instead of hard-coded ones. Also some clean-up of test code. Merging this as soon as it passes CI tests.

@dereklieu dereklieu changed the title Upgrade codemirror Upgrade dependencies Apr 20, 2016
@dereklieu dereklieu merged commit 25f151b into master Apr 20, 2016
@dereklieu dereklieu deleted the upgrade-codemirror branch April 20, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants