Implementing keyboard shortcut for toggling between edit and preview … #875
Conversation
|
That is pretty handy, indeed. @dereklieu Tests are passing. Functionality works as expected. Thoughts on the key combination and merging? Phillip. |
| }, | ||
| "shortcuts": { | ||
| "title": "Shortcuts", | ||
| "content": "<p>Press <code>Ctrl-S</code> to commit your changes. <br/> Press <code>Ctrl-Enter</code> to toggle between editing and previewing.</p>\n" |
There was a problem hiding this comment.
So these translations are generated from Transifex by running the gulp translations task, and as soon as we publish a new translation, say someone contributes a new language and we need to deploy it, then your text here would get wiped out.
@mikemorris am I right in thinking that if we went in and changed the english phrasing of this in Transifex, then all the other language translations would be out of sync? Not a huge deal for this but definitely seems to be a pain if for example we need to change bigger chunks of critical text?
There was a problem hiding this comment.
Sort of, I think other translations would just bump down from 100% to 98% complete if we added a new English string in Transifex. Not sure how it would handle changing a source phrase - @tristen?
There was a problem hiding this comment.
Sort of, I think other translations would just bump down from 100% to 98% complete if we added a new English string in Transifex.
Yep exactly.
Not sure how it would handle changing a source phrase
There's no specific handling. The new addition just needs to be account for in the application.
There was a problem hiding this comment.
@tristen Will changing an English phrase in Transifex flag translations of that phrase as possibly outdated though?
There was a problem hiding this comment.
Oh I see. I am 99% certain Transifex flags translations as outdated when the source file (en) is updated. It's been awhile since I've used it though.
There was a problem hiding this comment.
@dereklieu, sorry, I didn't realize those files were generated.
I can move that text to the proper location if that helps.
…in editor.
I love that the Ctrl-S shortcut is working, but was frustrated about the lack of shortcut for going into preview mode and back to editing mode.
So I implemented it. I verified on my local deployment that it works.
I picked Ctrl-Enter, but feel free to pick whichever combination works best. The only caveat is that some combinations interfere with the browser (for instance, I was using Ctrl-E at first, which worked but also moved the caret into the URL bar).
Let me know if this is acceptable or if there is anything I can do.
Cheers,
Julien