Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Validation failed" uploading a file #543

Closed
tristen opened this issue Jul 30, 2013 · 4 comments
Closed

"Validation failed" uploading a file #543

tristen opened this issue Jul 30, 2013 · 4 comments
Labels
bug
Milestone
Priority

Comments

@tristen
Copy link
Member

tristen commented Jul 30, 2013

When uploading a .jpg file I receive a validation error back. Possibly related is the issue cited here #181 (comment)
@josephers
Copy link

I get this error in my Chrome 28 console when uploading from my disk via the filepicker:

Uncaught TypeError: Cannot read property 'files' of undefined

And if I drag/drop, then in my network requests I can see that the Github API server returned a validation error for unprocessable entity:

{"message":"ValidationFailed",
 "errors": [{
   "resource":"Commit",
   "field":"message",
   "code":"missing_field"
   }]
}

I think it's missing a commit message for the image upload?

@josephers
Copy link

Hooray, so fast! Thanks so much. Can't wait to see it live!

@mikemorris
Copy link
Contributor

@josephers Pushed live, should be working now!

@josephers
Copy link

@mikemorris So awesome!! Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Priority
Development

No branches or pull requests
3 participants
@tristen @josephers @mikemorris