-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is Proptest abandoned? #268
Comments
There's an updated fork here: https://github.com/nzeh/proptest. I don't really have the intention of taking over maintainership of this crate. I'll submit a pull request shortly and would prefer that my changes get incorporated into the main repo. My fork addresses two issues, alas via (hopefully minor) breaking changes:
|
Unless either of you have been contacted in private, it seems at this point like the library has been abandoned. @nzeh should your fork be designated the new official one? Should a new organization be formed to host the project with new owners? |
There has been no response. I'm reluctant to have my fork designated the official one because my ability to dedicate time to this project is really unpredictable. There will likely be long stretches when I wouldn't be able to put any time aside for this, so it would likely end up in the same situation as the current official repo and at least seem abandoned. I'd be more than happy to be part of a team that co-maintains official fork. |
We at Ditto (https://github.com/getditto) have been leaning pretty heavely on Proptest. We have a fork that we are using. Happy to discuss with management about us taking ownership. Spoke with @tzemanovic about this a little too. What do people think of that? |
I'm good with that (not that I feel a single commit gives me a major say in that anyway :) ). |
Hi all, apologies for my long silence here. To answer the title question: Yes, pretty much. I had gotten completely burnt out after I started burning almost every weekend dealing with questions/features. At this point I'd be happy to help transfer ownership if a suitable org were set up (or if Ditto itself wants to take it). My only reservation with transferring to an individual is the potential for abuse (no offence to any of you — I'm just overly cautious) but if they have already established trust in the community that would be fine too. |
Good to hear from you! I've spoken to colleagues at Ditto, and we'll take it on, if that is acceptable to you and the wider community |
I'd prefer if an org that was associated with the community at large was built. I think that's preferable to the longevity of a library since it can then be grounded in a more diverse subset of the community, also given how important of a role this library plays across rust. Of course the challenging part is establishing that initial set of owners. |
FWIW my employer also has a fork at https://github.com/input-output-hk/proptest that is lightly maintained (only a few minor features added like const generics). We heavily rely on proptest, and have got huge value from it. I'd be happy to dedicate some personal time to helping out. As for who the ownership should go to, I largely agree that a community organization would be ideal, but I'd also be happy with Ditto, especially if that means people are getting paid for the maintenance 😁 |
@AltSysrq would you be able to start a new organization, add interested parties as owners, and transfer ownership to this organization? |
Just an idea. Maybe a @rust-fuzz would be a right home for this project? It consists of established and trusted members of Rust community and property-based testing and fuzzing are closely related. However, I am not part of the organization So we would need to talk to them to find out whether they would be interested. I would not like to drop responsibilities on someone. Maybe at the begining they could have the deployment rights and act as an authority. |
I'd be fine with either, but in the interest of getting this done, I'm inclined to take the path we can go unilaterally; i.e., the new org. Specifically:
|
I'm open to taking a stake in ownership, however, my main contributions being code review and issue review. There are some additions I've wanted to make to proptest but I have yet to have the capacity to commit time to them. If we are to create a new org rather than relying on rust-fuzz, we'll need to negotiate how we conduct business (e.g. how many different reviewers' approval before merge; do we meet at any cadence or only use asynchronous comms; what are the channels; etc.). However, the new org can also decide to try and transfer ownership to them after all. Just some bits I feel are necessary to raise, I'm on board with this plan assuming others are too 👍 |
I'm interested in taking a stake in ownership, pending some conversations and approval from my employer. |
I'd also be happy to take some stake in ownership. Agree with the above comments about needing some sort of process in place. We probably also need to think about how we reconcile everyone's respective forks. If it's useful, I can ask my employer if there's capacity for work time to be dedicated to maintenance 👍 |
@matthew-russo @cameron1024 Please do have those conversations if you can. (And sorry that I lost track of this again.) |
I'm good to help maintain. It would be in my free time though, just to set expectations clearly. |
I'm in the same boat. I usually have a fair amount of time on weekends. As for reconciling forks, I'm not sure what the best strategy is. Our company's fork only had a few trivial changes, not all of which should be included IMO. I'd be happy to open a PR to copy over the useful stuff (mainly just |
@russelldb Hey thanks for offering to take ownership of this project. Did your organization end up taking over? My company would also like to rely on this and if you haven't taken ownership or have some blocker we are up for it. If there is a separate repo you've set up, let us know. |
The subsequent discussions in this thread seemed to be pretty keen not to have some commercial entity "take ownership", so no, we did not. HOWEVER, it remains the case that there is no canonical continuation descendent owner of this repo. Ditto depend very much on an unmerged PR that adds stateful testing. And so we have to have a fork that we maintain. Currently I guess it is essentially "vendored". We would love for there to be a decision and progress made on a new home. |
I've set up the new org and invited @rex-remind101, @matthew-russo, @cameron1024 as members. I'll add to the |
Thanks for setting this up @AltSysrq! Just accepted the invite. Once @russelldb makes a decision I suggest we figure out comms channel and then from there discuss code review and, as others have said, how/in what order we'll review and merge what sounds like quite a few forks into our main repo. |
Yes please! Many thanks. |
Huh, I thought I'd be notified when the invitations were accepted. Anyway, I've set up a |
Hi yall, how would everyone prefer to communicate so we can start merging in people's forks? I could start a slack org and temporarily provide an invite link here as a suggestion? |
Slack works with me. |
Likewise, Slack is good for me too. |
Same here |
Ok, I will setup something tonight, thanks everyone 👍 |
@AltSysrq whenever you get the chance can you update the team you've already created to allow write access to the repository? Right now we can't merge any PRs. |
Whoops, should be fixed now. |
@matthew-russo @russelldb @AltSysrq Would you all be willing to have me join the group of maintainers as well? I'd like to contribute :) |
@seanmajorpayne I can help you join if you are still interested. Here's a link to slack, I can help you there https://join.slack.com/t/proptest-rs/shared_invite/zt-1lk8opcx1-Ssh6G0sQjEwGm6AouCtKUQ I'll be closing this topic now :) |
Hey, sorry I'm late to the party! I'd be interested in joining slack and the maintenance team. Could you provide a fresh link? The last one is expired |
@rex-remind101 bump |
@tzemanovic https://join.slack.com/t/proptest-rs/shared_invite/zt-1rwigqgdf-AI4jWy6u3w27bOm5R9fN9Q this one shouldn't be time-limited. i'll look in to adding this to our CONTRIBUTING page. In general though anyone is welcome to open issues and PRs. The slack workspace is primarily just for some discussion on what we're working on or what we want each other to look at. |
There are a lot of open PRs, the project's own tests no longer pass (since #258) (TBH I can't even get the tests to compile)
Not to be one of those entitled downstream users, but can @AltSysrq please let us know the state of the project, or if someone should fork/takeover as the canonical crate?
Many thanks in advance
The text was updated successfully, but these errors were encountered: