[MV-1799][FIX] ECF Filter bugfix of segfault when **buff==NULL
used
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the file
sdk/modules/driver/cpp/3rdparty/hdf5_ecf/ecf_h5filter.h
I have found a bug when using the function param**void buf
inH5Z_filter_ecf(...)
. The implementation of functorH5Z_func_t
does not explicitly have a safeguard which protects**void buf == NULL
meaning that when a call like:H5Z_filter_ecf(..., NULL)
occurs and you perform this operation inH5Z_filter_ecf
:inbuf = *buf;
you will get a segfault.