Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration processing #461

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Fix configuration processing #461

merged 1 commit into from
Aug 31, 2017

Conversation

nicolas-grekas
Copy link
Contributor

@nicolas-grekas nicolas-grekas commented Aug 29, 2017 •
edited
Loading

Not calling the Extension::processConfiguration() method prevents tracking env vars correctly, as spotted in symfony/symfony#24020.

This was referenced Aug 29, 2017
Closed
Merged
@marcj
Copy link
Member

marcj commented Aug 31, 2017

Thanks. See symfony/symfony#24021 (comment)

@marcj marcj merged commit 9536a71 into propelorm:3.0 Aug 31, 2017
@othillo othillo mentioned this pull request Oct 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

@xabbuh xabbuh xabbuh approved these changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @marcj @fabpot @xabbuh @chalasr