Fix regression: allow using custom methods. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to be able to use our own methods to generate the `$choiceLabel`, instead of just the columns of the object. Now, Propel complains about the column not existing in the object.
|
I'm not experienced with pull-requests. This PR is to merge a commit into the 3.0 branch, however the problem also (or just?) exists in the 1.5 branch (which we are using). Should we create a second pull-request with the same change, for this other branch? Second question: the PR has been created 21 days ago and nothing happend since. What has to happen before it will be merged? |
|
@marcj There are a few PRs with tests passing, here. Could you please take some time to review and merge them? That would be awesome! Thanks! |
| $choiceLabel = function($choice) use ($valueProperty) { | ||
| $getter = 'get'.ucfirst($valueProperty); | ||
| if (!method_exists($choice, $getter)) { | ||
| $getter = 'get' . ucfirst($query->getTableMap()->getColumn($valueProperty)->getPhpName()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to be able to use our own methods to generate the
$choiceLabel, instead of just the columns of the object. Now, Propel complains about the column not existing in the object.