Remove catch exception #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this is broken -vvv and don't show stack trace
| '[Propel] Exception caught', | ||
| '', | ||
| $e->getMessage() | ||
| ), 'fg=white;bg=red'); |
There was a problem hiding this comment.
Instead of removing the whole try block, we should rather just re-throw the exception after writing to the output.
There was a problem hiding this comment.
@marcj Why?
Default console error
[Propel] Exception
text
and red color
Custom console error
[Propel] Exception caught
text
and red color.
What is the difference? Replaced "[Propel] Exception" to "[Propel] Exception caught"?"
There was a problem hiding this comment.
Well, you are right, not much of a difference. Lets merge this :)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this is broken -vvv and don't show stack trace