Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the semicolon before dbname #416

Merged
merged 1 commit into from
May 10, 2016
Merged

remove the semicolon before dbname #416

merged 1 commit into from
May 10, 2016

Conversation

LeoOnTheEarth
Copy link
Contributor

@LeoOnTheEarth LeoOnTheEarth commented Apr 30, 2016 •
edited
Loading

A dsn like mysql:host=localhost;dbname=foo
After preg_replace, the dsn become mysql:host=localhost;
If we have additional setting "charset: utf8", the dsn will become mysql:host=localhost;;charset=utf8, which makes propel:database:create command not working

@LeoOnTheEarth
remove the semicolon before dbname
0bdf585 
A dsn like "mysql:host=localhost;dbname=foo"
After preg_replace, the dsn become "mysql:host=localhost;"
If we have additional setting "charset: utf8", the dsn will become "mysql:host=localhost;;charset=utf8", which make propel:database:create not working
@marcj marcj merged commit f984bb5 into propelorm:3.0 May 10, 2016
@marcj
Copy link
Member

marcj commented May 10, 2016

Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoOnTheEarth @marcj