Update PropelParamConverter.php #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add "query_method" option equivalence of "repository_method" in doctrine
|
Thanks @arffak, can you please fix CS? |
|
@marcj FIX CS done |
| throw new \LogicException('Unable to guess how to get a Propel object from the request information.'); | ||
| $this->queryMethod = $queryMethod = isset($options['query_method']) ? $options['query_method'] : null; | ||
|
|
||
| if ($this->queryMethod != null and \method_exists($classQuery, $this->queryMethod)) { |
There was a problem hiding this comment.
and \method_exists => && method_exists
|
done |
| throw new \LogicException('Unable to guess how to get a Propel object from the request information.'); | ||
| $this->queryMethod = $queryMethod = isset($options['query_method']) ? $options['query_method'] : null; | ||
|
|
||
| if ($this->queryMethod != null and method_exists($classQuery, $this->queryMethod)) { |
|
👍 |
| @@ -50,6 +50,12 @@ class PropelParamConverter implements ParamConverterInterface | |||
| protected $withs; | |||
|
|
|||
| /** | |||
| * name of method use to call a query method | |||
| * @var string | |||
There was a problem hiding this comment.
There is blank line missing before the @var.
|
After applying the outstanding changes, could you please rebase and squash the commits? |
|
Thanks, I merged and fix this CS myself :) |
marcj
pushed a commit
that referenced
this pull request
Apr 13, 2016
* Update PropelParamConverter.php add "query_method" option equivalence of "repository_method" in doctrine * FIX CS * FIX CS * \method_exists => && method_exists * and => &&
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add "query_method" option equivalence of "repository_method" in doctrine