Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup API and docblocks #1862

Merged
merged 6 commits into from
Apr 7, 2022
Merged

Cleanup API and docblocks #1862

merged 6 commits into from
Apr 7, 2022

Conversation

dereuromark
Copy link
Contributor

baselines got cleaned up quite a bit.

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022 •
edited
Loading

Codecov Report

Merging #1862 (9539917) into master (0390dea) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1862      +/-   ##
============================================
- Coverage     87.58%   87.58%   -0.01%     
  Complexity     7791     7791              
============================================
  Files           227      227              
  Lines         21108    21106       -2     
============================================
- Hits          18488    18486       -2     
  Misses         2620     2620
Flag Coverage Δ
5-max 87.58% <100.00%> (-0.01%) ⬇️
7.4 87.58% <100.00%> (-0.01%) ⬇️
agnostic 66.91% <100.00%> (+<0.01%) ⬆️
mysql 68.84% <83.33%> (+<0.01%) ⬆️
pgsql 68.86% <83.33%> (+<0.01%) ⬆️
sqlite 66.68% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/Generator/Behavior/Delegate/DelegateBehavior.php 90.22% <ø> (ø)
...stedSet/NestedSetBehaviorObjectBuilderModifier.php 96.65% <ø> (ø)
...estedSet/NestedSetBehaviorQueryBuilderModifier.php 90.81% <ø> (ø)
...Sortable/SortableBehaviorObjectBuilderModifier.php 95.39% <ø> (ø)
.../Sortable/SortableBehaviorQueryBuilderModifier.php 92.73% <ø> (-0.05%) ⬇️
...r/Behavior/Timestampable/TimestampableBehavior.php 94.33% <ø> (-0.11%) ⬇️
src/Propel/Generator/Builder/Om/ObjectBuilder.php 94.16% <ø> (ø)
src/Propel/Generator/Builder/Om/QueryBuilder.php 89.98% <ø> (-0.02%) ⬇️
...rc/Propel/Generator/Builder/Om/TableMapBuilder.php 95.27% <ø> (ø)
src/Propel/Runtime/Map/ColumnMap.php 82.82% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0390dea...9539917. Read the comment docs.

@dereuromark dereuromark changed the title Bugfix/cleanup Cleanup API and docblocks Apr 7, 2022
@dereuromark dereuromark merged commit 80b6981 into master Apr 7, 2022
@dereuromark dereuromark deleted the bugfix/cleanup branch April 7, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limeeugenia limeeugenia limeeugenia approved these changes

Assignees
No one assigned
Labels
BC-break 2.0 Bug Compatibility issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereuromark @codecov-commenter @limeeugenia