Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up phpstan baseline. #1851

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Fix up phpstan baseline. #1851

merged 4 commits into from
Mar 28, 2022

Conversation

dereuromark
Copy link
Contributor

@dereuromark dereuromark commented Mar 28, 2022

Afterwards we should

vendor/bin/phpstan -b

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #1851 (5301a07) into master (94069d2) will not change coverage.
The diff coverage is 70.00%.

@@            Coverage Diff            @@
##             master    #1851   +/-   ##
=========================================
  Coverage     87.75%   87.75%           
+ Complexity     7761     7758    -3     
=========================================
  Files           282      282           
  Lines         21291    21291           
=========================================
  Hits          18684    18684           
  Misses         2607     2607           
Flag Coverage Δ
5-max 87.75% <70.00%> (ø)
7.4 87.75% <70.00%> (ø)
agnostic 66.92% <70.00%> (ø)
mysql 69.02% <60.00%> (+<0.01%) ⬆️
pgsql 69.03% <60.00%> (ø)
sqlite 66.87% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Generator/Platform/PgsqlPlatform.php 95.03% <25.00%> (-0.02%) ⬇️
src/Propel/Generator/Builder/DataModelBuilder.php 89.32% <100.00%> (+0.10%) ⬆️
src/Propel/Generator/Config/GeneratorConfig.php 96.87% <100.00%> (ø)
src/Propel/Generator/Model/Database.php 73.98% <100.00%> (ø)
src/Propel/Generator/Model/ForeignKey.php 94.64% <100.00%> (ø)
src/Propel/Generator/Platform/MysqlPlatform.php 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94069d2...5301a07. Read the comment docs.

@dereuromark dereuromark merged commit caa050b into master Mar 28, 2022
@dereuromark dereuromark deleted the cleanup-baseline branch March 28, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants