fixes duplicate keys in normalizedColumnNameMap #1726
Conversation
There was a problem hiding this comment.
Hey @hsgnitz,
this looks good. I like how the method starts to resemble code, instead of ascii-art. If you want to fully convert it, I have added some suggestions below. Though this is already a big improvent.
Let me know if you have questions about setting up the tests.
Best,
Moritz
hsegnitz
force-pushed
the
fix-duplicate-array-keys-in-table-map
branch
from
2eb1e4b to
663067c
Compare
hsegnitz
force-pushed
the
fix-duplicate-array-keys-in-table-map
branch
from
663067c to
aa31134
Compare
|
I rebased it to the current master. Anything else I need to do? Do we need to resolve the discussions? |
|
Hey @hsegnitz, I submitted another PR last week, and I think it blew their capacities. Now I am holding back, not to get in the way of a new contributor. I had hoped, that running the tests would have been approved by now, but what can you do, it takes as long as it takes. Anyway, again, sorry for not mentioning it earlier. Best, |
The generated code duplicates keys in the normalized column name map array in certain cases where two variants of how to specify a column accidentally create the exact same spelling.
For example the spelling of a single word column name is the same when using camelcase or snake_case. PHP ignorhes this but many tools flag this as a potential error, hence this fix.
Marked draft as I have to figure out the unit tests