Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes - update phpunit.xml.dist and MySQL 8 fixes #1725

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

mringler
Copy link
Contributor

@mringler mringler commented Apr 22, 2021

Played around with the tests a bit and fixed some things:

  1. Updated the phpunit.xml.dist to get rid of the warning when starting phpunit:
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Basically, they changed how code coverage tool configuration is done. New version works (tested it with phpunit/php-code-coverage).

  1. When running the test in the mysql group, a migration test failed because it uses the integer display width property (as in INTEGER(2)), which was removed in MySQL 8.0.19 (see here). The test is now skipped on MySQL
  2. Updated a MySQL-only test, that used an incorrect query. The query used the table name to access a column in a subquery, instead of the subquery alias. Hard to say why this fails now/on MySQL 8, since it is a semantic problem unrelated to the DBMS. It might have worked before Bugfix/column names from subquery #1714 (even though the test did not fail there). Anyway, I changed the alias, now it works.

@dereuromark dereuromark merged commit b62fd29 into propelorm:master Apr 22, 2021
@mringler mringler deleted the test_fixes branch April 22, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants