Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run sql:build model:build config:convert post-init #1236

Merged

Conversation

benbankes
Copy link
Contributor

@benbankes benbankes commented Jul 4, 2016

Runs the next commands required to be able to use Propel

@benbankes
Copy link
Contributor Author

@mpscholten Is there any reason we would not want to run the following commands directly after everything else in the init command?
sql:build
model:build
config:convert

Is there something lacking in this PR that needs to be written before it is mature enough to be pulled into the codebase?

{
$this->getApplication()->setAutoExit(false);

$followupCommands = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call this followUpCommands (I guess the english word for this is "follow up" and thus the camel case version would be "followUp" instead of "followup")

@mpscholten
Copy link
Member

Very cool idea :)

@marcj anything missing to get this merged?

@marcj
Copy link
Member

marcj commented Jul 25, 2016

Well, no, I just waited for your feedback :)

@marcj marcj merged commit e725b85 into propelorm:master Jul 25, 2016
@marcj
Copy link
Member

marcj commented Jul 25, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants