Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current master fails on OSX #427

Closed
marcj opened this issue Aug 12, 2013 · 5 comments
Closed

Current master fails on OSX #427

marcj opened this issue Aug 12, 2013 · 5 comments

Comments

@marcj
Copy link
Member

marcj commented Aug 12, 2013 

-marc~/Propel2-test (master)$ php54 ./bin/propel test:prepare
Building fixtures in tests/Fixtures/bookstore                 
Successfully wrote PHP configuration in file "./build/conf/bookstore-conf.php".
Building fixtures in tests/Fixtures/bookstore-packaged        
Successfully wrote PHP configuration in file "./build/conf/bookstore-packaged-conf.php".
Building fixtures in tests/Fixtures/namespaced                
Successfully wrote PHP configuration in file "./build/conf/bookstore_namespaced-conf.php".
Building fixtures in tests/Fixtures/reverse/mysql             
Successfully wrote PHP configuration in file "./build/conf/reverse-bookstore-conf.php".
Building fixtures in tests/Fixtures/reverse/pgsql             
No "build.properties.dist" file found, skipped.
Successfully wrote PHP configuration in file "./build/conf/reverse-bookstore-conf.php".
Building fixtures in tests/Fixtures/schemas                   
Successfully wrote PHP configuration in file "./build/conf/bookstore-schemas-conf.php".
-marc~/Propel2-test (master)$ php54 vendor/phpunit/phpunit/phpunit.php --stop-on-failure
PHPUnit 3.7.24 by Sebastian Bergmann.

Configuration read from /Users/marc/Propel2-test/phpunit.xml.dist

..SS.........................................................   61 / 2857 (  2%)
.............................................................  122 / 2857 (  4%)
.............................................................  183 / 2857 (  6%)
...............................................S.............  244 / 2857 (  8%)
.............................................................  305 / 2857 ( 10%)
.............................................................  366 / 2857 ( 12%)
...........................................S.................  427 / 2857 ( 14%)
.............................................................  488 / 2857 ( 17%)
................F

Time: 11.66 seconds, Memory: 131.25Mb

There was 1 failure:

1) Propel\Tests\Generator\Behavior\Validate\I18nConcreteInheritanceHandleValidateBehaviorTest::testI18nBehaviorHandlesValidateBehavior
Failed asserting that actual size 0 matches expected size 1.

/Users/marc/Propel2-test/tests/Propel/Tests/Generator/Behavior/Validate/I18nConcreteInheritanceHandleValidateBehaviorTest.php:38

FAILURES!
Tests: 505, Assertions: 1590, Failures: 1, Skipped: 4.

-marc~/Propel2-test (master)$ php54 -v
PHP 5.4.17 (cli) (built: Jul  5 2013 23:40:53) 
Copyright (c) 1997-2013 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2013 Zend Technologies
    with Xdebug v2.2.2, Copyright (c) 2002-2013, by Derick Rethans

The line:

$this->assertCount(1, $classMetadata->getConstrainedProperties());

I have at the moment no idea why.
@marcj
Copy link
Member Author

marcj commented Aug 12, 2013

This commit broke it:
symfony/validator@a6a37dd#L0L34
The validator behaviour is broken since our base classes are abstract and after this commit only non-abstract classes are handled. Related to issue symfony/symfony#8589.

I believe the fix there is wrong, because the issue came from here symfony/symfony#3179 which was intended to fix a call of a interface static method, not of a abstract static method.

@marcj
Copy link
Member Author

marcj commented Aug 12, 2013

Ok, fix is outstanding. symfony/symfony#8728

@willdurand
Copy link
Contributor

Great!

@marcj marcj mentioned this issue Aug 14, 2013
Merged
@robin850
Copy link
Member

Since Marc's pull request has been merged, maybe we can close this one?

willdurand added a commit that referenced this issue Sep 1, 2013
@willdurand
Merge pull request #437 from lunika/master
fdbccaa 
issue #427 fix, use symfony/validator ~2.2 again
@hhamon
Copy link
Member

hhamon commented Sep 7, 2013

Can this issue be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@willdurand @hhamon @robin850 @marcj