Cleanup non-standard ENV var setup #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysadmind
requested changes
Jan 19, 2022
|
After this PR gets merged, I think there are a few things that should follow. Adding them here just as a note.
|
SuperQ
force-pushed
the
bjk/fixup_env
branch
2 times, most recently
from
75a2418 to
35d92a5
Compare
|
Yes, the helm chart is here: https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-elasticsearch-exporter |
sysadmind
approved these changes
Jan 19, 2022
Drop ENV vars from flags as this is non-standard in the Prometheus ecosystem. * Remove es.apiKey flag to avoid credential leaks. Signed-off-by: SuperQ <superq@gmail.com>
sysadmind
approved these changes
Jan 19, 2022
iishabakaev
pushed a commit
to iishabakaev/elasticsearch_exporter
that referenced
this pull request
Jun 8, 2022
Drop ENV vars from flags as this is non-standard in the Prometheus ecosystem. * Remove es.apiKey flag to avoid credential leaks. Signed-off-by: SuperQ <superq@gmail.com>
|
No offence, but changes like this should never make it into a minor release (1.4.0) like this. It goes against the very foundation of the SemVer philosophy. 😐 It's fine to make changes like this, but please, please try to do a major version bump in the future. It's much better for everybody that way. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop ENV vars from flags as this is non-standard in the Prometheus
ecosystem.
Signed-off-by: SuperQ superq@gmail.com