Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent lexer from seeking to next rune after lexing escape sequence. #8517

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Prevent lexer from seeking to next rune after lexing escape sequence. #8517

merged 3 commits into from
Feb 19, 2021

Conversation

dannykopping
Copy link
Contributor

Fixes #8515

Prevent lexer from seeking to next rune after lexing escape sequence.
ac76586 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
This was referenced Feb 18, 2021
Closed
Closed
Danny Kopping added 2 commits February 18, 2021 15:15
Testing if CI runs tests.
df8e025 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Fixing comment formatting
57024b4 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@roidelapluie roidelapluie reopened this Feb 18, 2021
@roidelapluie
Copy link
Member

Closed/Open to have CI

@dannykopping
Copy link
Contributor Author

Thanks @roidelapluie! That looks like it did the trick

@roidelapluie roidelapluie merged commit 42a0e0a into prometheus:master Feb 19, 2021
@roidelapluie
Copy link
Member

Thanks!

@dannykopping dannykopping deleted the dannykopping/fix-escape-sequence-parse branch February 19, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lexer advances too far when label value ends with escape sequence, causing parse error
2 participants
@dannykopping @roidelapluie