Add image name meta label to DO service discovery #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The label `__meta_digitalocean_image` expose the `slug` of the image and the `slug` is only present in the public images. To refer a user-generated image (`snapshot` or `custom`) we can use the image's display name. See: https://developers.digitalocean.com/documentation/v2/#images Signed-off-by: Matteo Valentini <matteo.valentini@nethesis.it>
|
Sorry to ask that, but can you fix the DCO? |
Co-authored-by: Julien Pivotto <roidelapluie@gmail.com> Signed-off-by: Matteo Valentini <matteo.valentini@nethesis.it>
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label
__meta_digitalocean_imageexpose theslugof the image andthe
slugis only present in the public images.To refer a user-generated image (
snapshotorcustom) we can usethe image's display name.
See: https://developers.digitalocean.com/documentation/v2/#images
Signed-off-by: Matteo Valentini matteo.valentini@nethesis.it