Recommend to get promtool from a binary distribution. #8491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than compile it yourself, which doesn't work as shown anymore because of Go Modules. Signed-off-by: beorn7 <beorn@grafana.com>
|
Thanks! |
|
Should we cherry-pick it in release-2.25? |
|
I think it's just a minor annoyance, but your call. |
|
Please cherry pick. It is not minor since it happens at the moment we remove the vendor directory. |
|
Good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than compile it yourself, which doesn't work as shown anymore
because of Go Modules.