Initial API v1 implementation #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "github.com/prometheus/prometheus/web/api" | ||
|
|
||
| api_legacy "github.com/prometheus/prometheus/web/api/legacy" | ||
| api_v1 "github.com/prometheus/prometheus/web/api/v1" |
fabxc
force-pushed
the
fabxc/api-v1
branch
2 times, most recently
from
ce6000f to
9f839ab
Compare
| "github.com/prometheus/prometheus/web/api" | ||
|
|
||
| legacy "github.com/prometheus/prometheus/web/api/legacy" | ||
| v1 "github.com/prometheus/prometheus/web/api/v1" |
There was a problem hiding this comment.
The renaming is not even required in that case. The package is called v1 anyway.
|
Perhaps rename Who else is about to review this? @juliusv ? |
| @@ -41,7 +41,9 @@ import ( | |||
| "github.com/prometheus/prometheus/storage/remote/influxdb" | |||
| "github.com/prometheus/prometheus/storage/remote/opentsdb" | |||
| "github.com/prometheus/prometheus/web" | |||
| "github.com/prometheus/prometheus/web/api" | |||
|
|
|||
There was a problem hiding this comment.
There should be no newline here as per our import group conventions...
|
👍, but note my latest two comments on the design doc (ok to encode timestamp/values as tuples also for vectors, and not needing a special endpoint for metrics names). |
|
Merging these basics so we have the changes in |
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this pull request
Oct 12, 2017
These labels were added in: prometheus#2506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add an initial API v1 that provides the equivalent endpoint to the old API accepting unix or RFC3339 timestamps.
Both APIs are running in parallel.