PromQL: Support trailing commas in grouping opts #6480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation somewhere should also change with this. |
Fixes prometheus#6470 Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
slrtbtfs
force-pushed
the
grouping_commas
branch
from
ceae173 to
ebe625f
Compare
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
|
I've added documentation about trailing commas. |
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
| all other labels are preserved the output. `by` does the opposite and drops | ||
| labels that are not listed in the `by` clause, even if their label values are | ||
| identical between all elements of the vector. | ||
|
|
||
| `parameter` is only required for `count_values`, `quantile`, `topk` and |
There was a problem hiding this comment.
This makes it seem as though it's an option for the others. I'd say used rather than required.
There was a problem hiding this comment.
I personally find "required" more clear than "used" here.
Also this wording was not introduced by this PR.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6470
Signed-off-by: Tobias Guggenmos tguggenm@redhat.com