Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrape: close manager gracefully at end. #6044

Merged
merged 1 commit into from
Sep 23, 2019
Merged

scrape: close manager gracefully at end. #6044

merged 1 commit into from
Sep 23, 2019

Conversation

johncming
Copy link
Contributor

juliusv
juliusv reviewed Sep 22, 2019
View reviewed changes
scrape/manager_test.go Outdated Show resolved Hide resolved
@johncming
scrape: close manager gracefully at end.
511ad21 
Signed-off-by: johncming <johncming@yahoo.com>
@juliusv
Copy link
Member

juliusv commented Sep 23, 2019

👍 Thanks!

@juliusv juliusv merged commit 4757c69 into prometheus:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusv juliusv juliusv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johncming @juliusv